Add feature to bind to specific network interfaces via Thunderscope #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsarune
requested review from
williamckha,
sauravbanna,
a team,
aviwad and
suchirss
and removed request for
a team
nimazareian
reviewed
Jul 15, 2024
There was a problem hiding this comment.
I'm getting this error when I launch AI vs AI. Maybe the new ProtoLogger will fix this issue
2024-07-15 10:19:11,051 - [ERROR] - [Thread-33] - root - (threaded_unix_sender.py).__send_protobuf(65) - Received an invalid proto of type TbotsProto.ThunderbotsConfig
2024-07-15 10:19:11,054 - [ERROR] - [Thread-3] - root - (proto_logger.py).__log_protobufs(143) - Exception detected in ProtoLogger
Traceback (most recent call last):
File "/home/nima/.cache/bazel/_bazel_nima/d4d8c6a2a61c53de6e279fde073469b4/execroot/__main__/bazel-out/k8-fastbuild/bin/software/thunderscope/thunderscope_main.runfiles/__main__/software/thunderscope/replay/proto_logger.py", line 132, in __log_protobufs
log_entry = ProtoLogger.create_log_entry(proto, current_time)
File "/home/nima/.cache/bazel/_bazel_nima/d4d8c6a2a61c53de6e279fde073469b4/execroot/__main__/bazel-out/k8-fastbuild/bin/software/thunderscope/thunderscope_main.runfiles/__main__/software/thunderscope/replay/proto_logger.py", line 157, in create_log_entry
serialized_proto = base64.b64encode(proto.SerializeToString())
google.protobuf.message.EncodeError: Message TbotsProto.ThunderbotsConfig is missing required fields: ai_config.ai_control_config.network_config
2024-07-15 10:19:12,468 - [INFO] - [MainThread] - root - (proto_configuration_widget.py).update_proto_from_file(142) - Loading protobuf from file: /opt/tbotspython/thunderbots_configuration_proto/default_configuration.proto
|
Actually the error goes away when I delete my |
|
Yeah that's a known issue whenever |
williamckha
added a commit
that referenced
this pull request
Jul 16, 2024
williamckha
previously approved these changes
Sep 2, 2024
| * | ||
| * @return true if the IP address was found, false otherwise | ||
| */ | ||
| bool getLocalIp(const std::string& interface, std::string& ip_address, bool ipv4 = true); |
There was a problem hiding this comment.
Could return std::optional<std::string> to avoid the out parameter
williamckha
previously approved these changes
Sep 3, 2024
williamckha
previously approved these changes
Oct 19, 2024
williamckha
previously approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes:
How can you test?
Play around with
./tbots.py run thunderscope_main --run_blue --run_diagnostics --disable_communcationTesting Done
At home with different gamecontroller instances on my home network. The video binds to my local interface first, then an interface that isn't connected to a network and then a home interface that had a gamecontroller instance on it.
IMG_0028.mp4
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue